Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add execute sql boiler impl #49

Merged
merged 4 commits into from
Jul 25, 2023
Merged

Add execute sql boiler impl #49

merged 4 commits into from
Jul 25, 2023

Conversation

rylev
Copy link
Contributor

@rylev rylev commented Jul 21, 2023

Adds the boiler plate code for calling (as of yet non-existent) endpoint in nimbus for executing SQL.

@kate-goldenring
Copy link
Collaborator

@rylev as the sqld-proxy service is written and as Lookup and gluon are implemented, app_id is required for execute. I think in order to add this command, we need to update Lookup in gluon to allow for just project_id and name for a lookup. Then we can run spin cloud sqlite execute "BLAH". Otherwise, it is really hard right now for a user to know what db is associated with what app.

@rylev rylev marked this pull request as ready for review July 25, 2023 06:22
@rylev
Copy link
Contributor Author

rylev commented Jul 25, 2023

Ok this is ready. We no longer need to send app id so @kate-goldenring's concern above is addressed.

Signed-off-by: Ryan Levick <[email protected]>
@rylev rylev merged commit 4cb6728 into main Jul 25, 2023
8 checks passed
@rylev rylev deleted the execute-sql branch July 25, 2023 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants